Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ChangeSet from StoreView #3739

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

shargon
Copy link
Member

@shargon shargon commented Feb 11, 2025

Description

ChangeSet was removed when the Storage is readOnly, calls to NeoSystem.StoreView will be improved.

Fixes # (issue)

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Current tests

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon marked this pull request as ready for review February 11, 2025 12:48
@shargon shargon changed the title Speed up Read only storage Remove ChangeSet from StoreView Feb 11, 2025
@shargon shargon added the Blocker Issues that are blocking other issues. Check issues details to see what it is blocking. label Feb 13, 2025
@shargon
Copy link
Member Author

shargon commented Feb 13, 2025

I need this for StorageCache, because when is ReadOnly, the cache must write in the main one, instead of the temporal, otherwise we dont' have a good performance

Related to: #3669

@shargon shargon requested a review from superboyiii February 14, 2025 12:11
@shargon
Copy link
Member Author

shargon commented Feb 14, 2025

@superboyiii could you test it?

@shargon
Copy link
Member Author

shargon commented Feb 22, 2025

Ping @neo-project/core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Issues that are blocking other issues. Check issues details to see what it is blocking. Waiting for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants